Skip to content

Conversation

@vchuravy
Copy link
Member

@maleadt
Copy link
Collaborator

maleadt commented Oct 16, 2025

Custom tests should also be transfomed, no? To cover the GPUArrays test suite.

@vchuravy
Copy link
Member Author

Custom tests should also be transfomed, no? To cover the GPUArrays test suite.

I was debating that. In OpenCL.jl I currently have:

for name in keys(GPUArraysTestSuite.tests)
    test = "gpuarrays/$name"
    custom_tests[test] = test_transform(test, :(GPUArraysTestSuite.tests[$name](CLArray)))
end

Because I was envisioning folks wanting to have control over what their custom tests are doing.
But I can also see the argument to just want to apply the transform consistently (and you could make transform decisions based on the test name).

@vchuravy vchuravy marked this pull request as ready for review October 17, 2025 14:58
@maleadt
Copy link
Collaborator

maleadt commented Oct 17, 2025

What about a tests::Dict{String, Expr} = ParallelTestRunner.discover_tests(pwd()) kwarg? That makes it clear that we default to running tests from files, makes it possible to override things by bringing your own tests (subsuming custom_tests), while obviating the need for a transform function as proposed here.

Would be a breaking change. Although I guess we could still support the old support_tests behavior in the mean time.

I guess that could then also do away with test_filter...

@vchuravy
Copy link
Member Author

Closed in favor of #57

@vchuravy vchuravy closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants